Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIES has changed XML response format #58

Closed
jwldk opened this issue Aug 12, 2022 · 7 comments
Closed

VIES has changed XML response format #58

jwldk opened this issue Aug 12, 2022 · 7 comments

Comments

@jwldk
Copy link

jwldk commented Aug 12, 2022

Seems as of today the VIES service has changed their XML response format.

pyvat.check_vat_number("DK12345678")
ValueError: expected response XML root element to be a SOAP envelope

The XML appears to be missing the soap:Envelope which the current implementation expects:

<env:Envelope xmlns:env="http://schemas.xmlsoap.org/soap/envelope/"><env:Header/><env:Body><ns2:checkVatResponse xmlns:ns2="urn:ec.europa.eu:taxud:vies:services:checkVat:types"><ns2:countryCode>DK</ns2:countryCode><ns2:vatNumber></ns2:vatNumber><ns2:requestDate>2022-08-12+02:00</ns2:requestDate><ns2:valid>false</ns2:valid><ns2:name>---</ns2:name><ns2:address>---</ns2:address></ns2:checkVatResponse></env:Body></env:Envelope>
@zoomie
Copy link
Contributor

zoomie commented Aug 12, 2022

Here is a fix for this issue -> #60

@lsaffre
Copy link

lsaffre commented Aug 17, 2022

I can confirm that zoomie's pull request works for me. And now I hope to get this released to PyPI because my test suites are failing.

@sowinski
Copy link

Same here with

pyvat.check_vat_number("ATU76127718")
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/home/git/myvenv/lib/python3.7/site-packages/pyvat/__init__.py", line 212, in check_vat_number
    country_code)
  File "/home/git/myvenv/lib/python3.7/site-packages/pyvat/registries.py", line 123, in check_vat_number
    'expected response XML root element to be a SOAP envelope'
ValueError: expected response XML root element to be a SOAP envelope

@sowinski
Copy link

Any idea how to contact the maintainer?

@MatinF
Copy link

MatinF commented Aug 19, 2022

We urgently need this fixed as well

@lsaffre
Copy link

lsaffre commented Aug 19, 2022

Maybe this project is orphaned. There are already 27 forks (https://github.com/iconfinder/pyvat/network/members), maybe one of them is ready to take over the maintenance. But we should try to contact the author, who should then give access on PyPI to somebody else.

@jwldk
Copy link
Author

jwldk commented Aug 23, 2022

Solved with latest patch.

@jwldk jwldk closed this as completed Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants