Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SidePane not initialising correctly when included in template #536

Closed
martinfitzg opened this issue Mar 28, 2015 · 1 comment
Closed

SidePane not initialising correctly when included in template #536

martinfitzg opened this issue Mar 28, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@martinfitzg
Copy link

Hello all,

Doing a few hello worlds here and I've put the "d-side-pane" along with a few others (see screen shot below) into a template in a custom widget. All worked ok when it was all stand alone in a html page but putting it into the template caused issues.

In the file ./deliteful/SidePane.js first line in the refreshRendering function there is

this.parentNode.style.overflow = "hidden";

It errors out here with the parentNode been null, if I change that to

if(this.parentNode != null){ this.parentNode.style.overflow = "hidden"; }

It works correctly, but I'm not 100% sure what the effects of that down the line are....

capture

@wkeese
Copy link
Member

wkeese commented Mar 31, 2015

I fixed this earlier this month in c042dfb.

@wkeese wkeese closed this as completed Mar 31, 2015
@wkeese wkeese added the bug label Mar 31, 2015
@wkeese wkeese added this to the 0.7.0 milestone Mar 31, 2015
@wkeese wkeese self-assigned this Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants