Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressBar: formatExtraMsg() presumably backwards in RTL mode #466

Closed
wkeese opened this issue Jan 22, 2015 · 1 comment
Closed

ProgressBar: formatExtraMsg() presumably backwards in RTL mode #466

wkeese opened this issue Jan 22, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@wkeese
Copy link
Member

wkeese commented Jan 22, 2015

ProgressBar currently has this code:

formatExtMsg: function (position, value, max) {
    return (this.isLeftToRight()) ? value + "/" + max : max + "/" + value;
},

That code is surely wrong. It should just return value + "/" + max regardless of isLeftToRight(). The reason is that HTML has to be semantically correct (i.e. if you look at the raw HTML code it needs to make sense), so the raw HTML code needs to say 1/5 not 5/1.

If the fraction is displayed incorrectly in RTL mode, then you should use CSS etc. to make it print correctly. dir=ltr hardcoded on that node, or style="direction: left", or even unicode directional characters.

Also, remember that it's not just about display. There's also likely a screen reader issue. But even if there isn't, the HTML needs to be semantically correct.

@semion1956?

@semion1956
Copy link
Contributor

You are right, "val/max" should be displayed the same in any direction.

@wkeese wkeese added the bug label Feb 8, 2015
@wkeese wkeese added this to the 0.7.0 milestone Feb 8, 2015
@wkeese wkeese closed this as completed in a1a5f0d Feb 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants