Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox and RadioButton labeling should be easier #442

Closed
dmandrioli opened this issue Jan 6, 2015 · 3 comments
Closed

Checkbox and RadioButton labeling should be easier #442

dmandrioli opened this issue Jan 6, 2015 · 3 comments
Assignees
Milestone

Comments

@dmandrioli
Copy link
Member

If you just drop some checkboxes and radiobuttons with default configuration, you get something like
image
Source: http://jsfiddle.net/ibmjs/c3kgt98w/

Labels alignment is weird and different between the two widgets:

  • Checkbox label is too high, the text baseline should be aligned with the bottom of the square
  • Radio label is too low
  • Checkboxes and Radiobuttons should be aligned

As an example, here is what you get using Bootstrap
image

@tkrugg
Copy link
Member

tkrugg commented Jan 6, 2015

I've been working on this, as part of issues #299 (comment) and #415

I fixed the outline, but also the alignement on radio buttons.
i'm about to send a PR but I need to work on it some more, even maybe include the fix for checkbox.

image

@AdrianVasiliu
Copy link
Contributor

Just to mention that adding vertical-align: middle to d-radio-button gives this result with your jsfiddle:

image

@wkeese
Copy link
Member

wkeese commented Mar 9, 2016

Fixed by 72810d2, 4dfd44b, and cf40d28.

@wkeese wkeese closed this as completed Mar 9, 2016
@wkeese wkeese modified the milestones: 0.8.2, 0.9.0 Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants