New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sslmode in the postgres connection string #1

Open

rizahmeds opened this issue Feb 29, 2024 · 1 comment

Labels

bug good first issue

rizahmeds commented Feb 29, 2024

flow/db/budget_db/connection.go

Line 30 in fc57ae7

    
           connectionString := fmt.Sprintf("host=%s port=%s user=%s password=%s dbname=%s", v.Host, v.Port, v.User, v.Password, v.DBName)

In the above postgres connection string sslmode is not mentioned. By default sslmode take the require parameter which is not good for local development purpose.
Ref: https://pkg.go.dev/github.com/lib/pq#hdr-Connection_String_Parameters

We should set that as sslmode=disable in .env file and if it is in production we can set different value.

The text was updated successfully, but these errors were encountered:

Owner

ibilalkayy commented Feb 29, 2024 •

edited

Loading

Thank you, @rizahmeds for pointing this out. I added the sslmode.

Here it is: Link

ibilalkayy added bug good first issue labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment