From aa993211bbabe9298c06418dc76818858364f55d Mon Sep 17 00:00:00 2001 From: Robert Swoboda <53216935+Gengar-i@users.noreply.github.com> Date: Tue, 20 Feb 2024 11:29:48 +0100 Subject: [PATCH] Fixes after code review --- .../Resources/public/js/scripts/core/doughnut.chart.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/bundle/Resources/public/js/scripts/core/doughnut.chart.js b/src/bundle/Resources/public/js/scripts/core/doughnut.chart.js index 4d25c2aff9..d6710be541 100644 --- a/src/bundle/Resources/public/js/scripts/core/doughnut.chart.js +++ b/src/bundle/Resources/public/js/scripts/core/doughnut.chart.js @@ -66,8 +66,10 @@ const { itemTemplate } = this.legendNode.dataset; const fragment = doc.createDocumentFragment(); const data = chart.data.datasets[0]; + data.legend.forEach((legendItem, index) => { dataLabelsMap.set(index, true); + const container = doc.createElement('div'); const renderedItemTemplate = itemTemplate .replace('{{ checked_color }}', data.backgroundColor[index]) @@ -112,11 +114,7 @@ return; } - if (checked) { - dataLabelsMap.set(datasetIndex, true); - } else { - dataLabelsMap.set(datasetIndex, false); - } + dataLabelsMap.set(datasetIndex, checked); } setLegendCheckboxes() {