From 02ecef90ec0ce3cb37f2752b8fb28b6648333abf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20Grabowski?= <michal.grabowski@ibexa.co>
Date: Fri, 10 Mar 2023 11:06:17 +0100
Subject: [PATCH] fixes after cr

---
 .../Resources/public/js/scripts/helpers/form.error.helper.js  | 4 +++-
 .../public/js/scripts/helpers/form.validation.helper.js       | 2 +-
 .../themes/admin/ui/form_fields/dropdown_widget.html.twig     | 1 +
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/bundle/Resources/public/js/scripts/helpers/form.error.helper.js b/src/bundle/Resources/public/js/scripts/helpers/form.error.helper.js
index e5ddaa7396..6bc39c4760 100644
--- a/src/bundle/Resources/public/js/scripts/helpers/form.error.helper.js
+++ b/src/bundle/Resources/public/js/scripts/helpers/form.error.helper.js
@@ -2,7 +2,9 @@
     // @deprecated, will be removed in 5.0
     ibexa.addConfig('helpers.formError', {
         formatLine: (...args) => {
-            console.warn('helpers.formError.formatLine method is deprecated and will be removed in 5.0');
+            console.warn(
+                'helpers.formError.formatLine method is deprecated and will be removed in 5.0, please use helpers.formValidation.formatErrorLine instead.',
+            );
 
             return ibexa.helpers.formValidation.formatErrorLine(...args);
         },
diff --git a/src/bundle/Resources/public/js/scripts/helpers/form.validation.helper.js b/src/bundle/Resources/public/js/scripts/helpers/form.validation.helper.js
index 252486e1ae..f6c15b4c76 100644
--- a/src/bundle/Resources/public/js/scripts/helpers/form.validation.helper.js
+++ b/src/bundle/Resources/public/js/scripts/helpers/form.validation.helper.js
@@ -1,7 +1,7 @@
 (function (global, doc, ibexa, Translator) {
     const formatErrorLine = (errorMessage) => {
         const errorIcon = `<svg class="ibexa-icon ibexa-icon--small ibexa-form-error__icon">
-            <use xlink:href="${window.ibexa.helpers.icon.getIconPath('warning-triangle')}"></use>
+            <use xlink:href="${ibexa.helpers.icon.getIconPath('warning-triangle')}"></use>
         </svg>`;
         const container = document.createElement('em');
         const errorMessageNode = document.createTextNode(errorMessage);
diff --git a/src/bundle/Resources/views/themes/admin/ui/form_fields/dropdown_widget.html.twig b/src/bundle/Resources/views/themes/admin/ui/form_fields/dropdown_widget.html.twig
index edbe2fa645..d7456d48b0 100644
--- a/src/bundle/Resources/views/themes/admin/ui/form_fields/dropdown_widget.html.twig
+++ b/src/bundle/Resources/views/themes/admin/ui/form_fields/dropdown_widget.html.twig
@@ -27,6 +27,7 @@
             is_selector: attr.is_selector|default(false),
             is_dynamic: attr.is_dynamic|default(false),
             has_select_all_toggler: attr.has_select_all_toggler|default(false),
+            placeholder: attr.placeholder|default(),
         } %}
     {% endif %}
 {%- endblock choice_widget -%}