Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty compounds mess up layout #60

Closed
ugurdogrusoz opened this issue Oct 5, 2022 · 4 comments
Closed

Empty compounds mess up layout #60

ugurdogrusoz opened this issue Oct 5, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@ugurdogrusoz
Copy link
Contributor

Looks like when there are empty compound nodes in the graph, these compound nodes are not taken into account, messing up the layout.

@ugurdogrusoz ugurdogrusoz added the bug Something isn't working label Oct 5, 2022
@hasanbalci
Copy link
Contributor

The problem was because of the hidden nodes in the compounds which make them empty. Now, user should give all elements to the layout including the hidden ones, but the layout will not consider hidden ones during the layout (actually spectral part considers but cose part doesn't consider).

@ugurdogrusoz
Copy link
Contributor Author

@hasanbalci thanks I confirm the fix with the extension demo.
@osamazafar980 can you please check this in IAM application as well (please note the comment above for its usage).

@osamazafar980
Copy link

I am still seeing some issues. The empty compound nodes are creating massive gaps which then gets overlapped by other compounds

@ugurdogrusoz
Copy link
Contributor Author

@osamazafar980 Please close this if you tested it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants