Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rpaht settings #72

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Update rpaht settings #72

merged 1 commit into from
Mar 12, 2020

Conversation

petricm
Copy link
Contributor

@petricm petricm commented Mar 12, 2020 •
edited
Loading

BEGINRELEASENOTES

  • Use "Always full RPATH" as as implemented in ROOT

ENDRELEASENOTES
The problem is that the build location is placed into LC_RPATH

objdump -x /Users/Shared/cvmfs/sft.cern.ch/lcg/releases/LCIO/02.13-28ace/x86_64-mac1015-clang110-opt/lib/liblcio.2.13.0.dylib
          cmd LC_RPATH
      cmdsize 104
         path /Users/mato/Development/releases/97rc3python3/LCIO/02.13/x86_64-mac1015-clang110-opt/lib (offset 12)

but on mac it should be

Load command 17
          cmd LC_RPATH
      cmdsize 32
         path @loader_path/../lib (offset 12)

all is crucial for LCG releases of mac binaries and downstream key4hep developments.

@petricm petricm requested a review from gaede March 12, 2020 12:35
gaede
gaede approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@gaede gaede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for fixing this.

@gaede gaede merged commit dd51ad9 into iLCSoft:master Mar 12, 2020
simonspa added a commit to allpix-squared/allpix-squared that referenced this pull request Mar 24, 2020
@simonspa
CMake: try to fix macOS RPATH issues, thanks @mpetric via iLCSoft/LCI…
ae62b95 
…O#72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaede gaede gaede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petricm @gaede