Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional children for Trans component #727

Closed
maksis opened this issue Feb 9, 2019 · 4 comments
Closed

Optional children for Trans component #727

maksis opened this issue Feb 9, 2019 · 4 comments
Labels
typescript

Comments

@maksis
Copy link

maksis commented Feb 9, 2019

https://react.i18next.com/latest/trans-component#alternative-usage fails with error Property 'children' is missing in type '{ defaults: string; values: { what: string; }; components: Element[]; }' but required in type 'TransProps'. when using version 10.0.3
@basslagter
Copy link

basslagter commented Feb 11, 2019 •
edited
Loading

Yes, same here. Fixed it by providing a child <Trans>{}</Trans> but does not seem like a sustainable solution

@jamuhl
Copy link
Member

jamuhl commented Feb 11, 2019

A pull request would be welcome...guess @rosskevin will then review that

@menthena
Copy link
Contributor

menthena commented Feb 11, 2019 •
edited
Loading

@rosskevin, could you please review this? #728

@menthena menthena mentioned this issue Feb 11, 2019
Merged
@rosskevin rosskevin changed the title TypeScript: failing example with v10 Optional children for Trans component Feb 11, 2019
@basslagter
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rosskevin @jamuhl @menthena @maksis @basslagter