-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typescript tests for v10 hooks (like we had in v9) #703
Comments
@rosskevin would be awesome if we could add that coverage back in v10 - a lot changed with using hooks but basic type definitions should already be there |
@jamuhl it looks like you dropped If leaving this as-is I would have two choices:
I suggest strongly that the |
@jamuhl would you have any objections to converting the |
@rosskevin ...would prefer keeping stuff separated... hm...might add a render prop like the HOC using the hook internally |
That would definitely be advisable, it would be mostly a search/replace instead of a major upgrade crisis where everyone is forced to roll their own. |
Get back the test coverage for the upcoming v10 (currently (soon) it is published as npm i react-i18next@next)
The text was updated successfully, but these errors were encountered: