UMD with 'process.env.NODE_ENV' occurence (dev/prod)

[UbikZ]

Hi there.

Describe the bug
Just want to use UMD build of react-i18next, but crashing because of process.env.NODE_ENV occurence inside development/production files.

Occurs in react-i18next version
https://unpkg.com/[email protected]/dist/umd/react-i18next.js
https://unpkg.com/[email protected]/dist/umd/react-i18next.min.js

To Reproduce
Steps to reproduce the behavior:

1. Go https://codepen.io/anon/pen/ZVdRNX
2. Check console

To Fix

1. npm i rollup-plugin-replace -D
2. In rollup.config.js :

• Import rollup-plugin-replace
• Add the plugin :

replace({
      'process.env.NODE_ENV': JSON.stringify(compress ? 'production' : 'development'),
}),

Thank's.

Gabriel.

[jamuhl]

that comes from react-is which is used by hoist-non-react-statics -> https://unpkg.com/[email protected]/index.js

we guard our calls like: https://github.com/i18next/react-i18next/blob/master/src/utils.js#L16

the only thing you can do is adding:

<script>process = { env: { NODE_ENV: 'production' } }</script>

[UbikZ]

Sorry, but I don't get it.

• https://unpkg.com/[email protected]/index.js -> CJS build
• https://unpkg.com/[email protected]/umd/react-is.development.js -> UMD build

The process.env.NODE_ENV is always computed in UMD builds in order to remove some code from the build if production mode is enabled or not.

If react-is does not need the block code inside the if (process.env.NODE_ENV !== "production") { in production, your react-i18next production build will not needed it neither.
Same, if react-is must have the bloc in development mode, your react-i18next dev build should always have it.

Am I missing something ?

[jamuhl]

Not working like that...building a module you pull in dependencies...those are commonjs independent of rollup outputting umd in the end -> therefore it ends up like it is.

If you like to create a build (hardcoded production and development) like react-is does it - feel free to provide that as a PR...would be highly appreciated

[UbikZ]

The pull-request #683 works like a charm for UMD build.
Can you check all is good for you ?
Thank's.

EDIT: I have just commit the package.json and rollup.config.js files, not the build one.

[jamuhl]

published in [email protected]