You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Proposals (all of which I can open a PRs for, if desired):
Allow i18nIsDynamicList to function correctly, even when child is not a list.
Rename i18nIsDynamicList to i18nIsDynamicContent (will be done in a backwards compatible way, i.e. both will exist for a time, maybe till v14)
Motivation
I believe this first proposal is actually a bugfix. Currently, the Trans component assumes that the child of an element with the i18nIsDynamicList prop is a list, which may not be the case. See the following example:
By adding a fragment, the child becomes a list, and therefore the content renders correctly. My proposal is to make it work without the need for a list.
If we make the above change, which seems to me to be a bugfix, it would make sense to rename the i18nIsDynamicList prop to something that better describes what it's for. I was thinking i18nHasDynamicChildren. We can make this change in a backwards compatible way (i.e. both i18nIsDynamicList and i18nHasDynamicChildren will exist for a time, maybe till v14)
Please let me know if these changes are welcome, in which case I'll make a PR!
The text was updated successfully, but these errors were encountered:
🚀 Feature Proposal / Possible bug fix
Hi there!
Proposals (all of which I can open a PRs for, if desired):
i18nIsDynamicList
to function correctly, even when child is not a list.i18nIsDynamicList
toi18nIsDynamicContent
(will be done in a backwards compatible way, i.e. both will exist for a time, maybe till v14)Motivation
i18nIsDynamicList
prop is a list, which may not be the case. See the following example:The above will not render correctly. However, the following does:
By adding a fragment, the child becomes a list, and therefore the content renders correctly. My proposal is to make it work without the need for a list.
i18nIsDynamicList
prop to something that better describes what it's for. I was thinkingi18nHasDynamicChildren
. We can make this change in a backwards compatible way (i.e. bothi18nIsDynamicList
andi18nHasDynamicChildren
will exist for a time, maybe till v14)Please let me know if these changes are welcome, in which case I'll make a PR!
The text was updated successfully, but these errors were encountered: