Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useTranslation keyPrefix - please bump peerDependency of i18next #1377

Closed
marek-tkaczyk opened this issue Sep 17, 2021 · 2 comments
Closed

Comments

@marek-tkaczyk
Copy link

I wanted to use a new feature, ability to supply keyPrefix into useTranslation hook.

const { t } = useTranslation('myTranslations', { keyPrefix: 'deeply.nested' })

I couldn't figure out why it didn't want to work,
so I started investigation into merged PRs and found out that I need to upgrade i18next package to at least 20.6 version.

No npm. or yarn informed me about this, because version of i18next as a peerDependency was not bumped up.
So please bump it to save others developers time for searching this.

@jamuhl
Copy link
Member

jamuhl commented Sep 17, 2021

peerDependency wasn't bumped up - because it is only needed for that one specific new feature which is a core feature..not a react-i18next feature

@jamuhl jamuhl closed this as completed Sep 17, 2021
@jamuhl
Copy link
Member

jamuhl commented Sep 17, 2021

will add a note to docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants