Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultConfig overwrites config*.yml settings #264

Open
mkrill opened this issue May 23, 2022 · 0 comments
Open

DefaultConfig overwrites config*.yml settings #264

mkrill opened this issue May 23, 2022 · 0 comments
Assignees

Comments

@mkrill
Copy link
Contributor

mkrill commented May 23, 2022

DefaultConfig() settings are loaded for every child config area:

if err := area.loadDefaultConfig(); err != nil {

Doing so, a DefaultConfig defined in a Flamingo module loaded for a child area overwrites config values set in a root config*.yml file. IMO, the DefaultConfig() should only loaded before loading config values set explicitly in config*.yml files.

This issue was already discussed with @SchiffFlieger . Details can also be discussed with him.

@karstenkoehler karstenkoehler self-assigned this May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants