Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Model out of date #41

Open
blockclin-mike opened this issue Jul 9, 2019 · 4 comments
Open

Client Model out of date #41

blockclin-mike opened this issue Jul 9, 2019 · 4 comments

Comments

@blockclin-mike
Copy link

I received a value in a business user's business type field of "PRIVATE_COMPANY" which is not supported in the client model's enum. This causes an exception. I've fixed it on my side, however a system wide model enumeration review on your side is probably warranted.

Best,
mike

@wmews-hw
Copy link
Collaborator

wmews-hw commented Jul 9, 2019

@blockclin-mike Could you help understand it better telling us:

  • what is the operation you are trying to perform?
  • what is the field in the payload that is causing this issue?

@blockclin-mike
Copy link
Author

In class HyperwalletUser -> enum BusinessType
you have : {CORPORATION, PARTNERSHIP}
I added : {CORPORATION, PARTNERSHIP, PRIVATE_COMPANY}

"PRIVATE_COMPANY" is coming back from the server.

@blockclin-mike
Copy link
Author

My larger concern is I'm not sure how many other enums are strewn throughout the client wrapper which have missing values. Is there a server-to-client sync performed periodically, or is this wrapper truly as-is?

@wmews-hw
Copy link
Collaborator

wmews-hw commented Jul 9, 2019

@blockclin-mike Thanks for the information. I'm gonna get this answer to you asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants