Improve error logging and debugging #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HYP-2278 Adjust error reporting in the case of a Runtime failure
In HYP-2261 I made some changes to error reporting, but I went slightly too far because if a Runtime internal error occurs, to the user it looks like their function never ended when they read the logs. |
jairad26
approved these changes
Sep 26, 2024
mattjohnsonpint
deleted the
mjp/hyp-2278-adjust-error-reporting-in-the-case-of-a-runtime-failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an internal runtime error occurs, we need the actual error reported without being user-visible, so that we get a Sentry alert. This makes sense, because the error wasn't in the user's code. However, they still need some indication that an error occurred, or the function run logs are incomplete.
I also added a small change to how
console.debugerrors are written whenHYPERMODE_DEBUG=true, so that we can better troubleshoot errors caused by user code.