make test fail if tx can be signed with no endorsements

Signed-off-by: Antoine Toulme <[email protected]>
hyperledger · Jan 20, 2022 · 7acb6f4 · 7acb6f4
1 parent 954ba2b
commit 7acb6f4
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/protoutil/txutils_test.go b/protoutil/txutils_test.go
@@ -229,9 +229,8 @@ func TestCreateSignedTx(t *testing.T) {
 			Status: int32(200),
 		},
 	}}
-	// TODO: Is it a problem that a TX can be signed with no endorsements
 	_, err = protoutil.CreateSignedTx(prop, signID, responses...)
-	require.NoError(t, err)
+	require.Error(t, err, "Expected error because no endorsements were present")
 
 	// success
 	responses = []*pb.ProposalResponse{{