Use Solidity custom errors

[nambrot]

Solidity 0.8 introduced more gas efficient custom errors: https://blog.soliditylang.org/2021/04/21/custom-errors/

@yorhodes tried to do it when deploying v1 but ran into issues with existing code not being able to handle custom errors well. IIUC, this actually still would be an issue anyways with application contracts containing those, but luckily ethers-rs recently seemed to have fixed it gakonst/ethers-rs#1549

[yorhodes]

Should reapply changes from #538

[asaj]

@nambrot @yorhodes do we still want to do this? Custom errors are significantly less readable, than strings, no?

[yorhodes]

@nambrot @yorhodes do we still want to do this? Custom errors are significantly less readable, than strings, no?

only less readable if the source code isn't verified

[nambrot]

I would say we shouldn't do this, tooling would need to have access to source code to indicate the error, i dont' think the gas savings are worth it

[nambrot]

@yorhodes I'm just gonna assume i have convinced you :P