Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for easier routing between http server and multiple grpc servers #410

Closed
xd009642 opened this issue Jul 23, 2020 · 4 comments
Closed
Labels
A-tonic C-enhancement Category: New feature or request

Comments

@xd009642
Copy link
Contributor

I have two gRPC services in my server, my main server and the health check. I'm also adding a HTTP endpoint via warp. So I tried to do this and found things didn't quite work. Assuming I'm not doing anything egregiously wrong, there might be some changes to tonic-health and #272 or an equivalent may be required.

I've created an example repository here: https://github.com/xd009642/tonic-route-warp-example

In the mean time I'll start hosting two servers listening at different ports but it would be nice if this would work 😄

@LucioFranco
Copy link
Member

Yeah, that PR is related we just need to find a way to return an easy to use service from the router.

@LucioFranco LucioFranco added A-tonic C-enhancement Category: New feature or request labels Jul 23, 2020
@xd009642
Copy link
Contributor Author

is there anything stopping #272 being merged? I saw there was one comment adding something but otherwise (at least to my untrained) eyes it looked pretty solid

@LucioFranco
Copy link
Member

@xd009642 we just need to address #272 (comment)

@alce
Copy link
Collaborator

alce commented Sep 20, 2020

I believe this was resolved on #419. Please re-open if there are further questions.

@alce alce closed this as completed Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tonic C-enhancement Category: New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants