Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shoud bump rust-version in Cargo.toml due to faild build with rustc 1.63 #3804

Closed
linyihai opened this issue Dec 2, 2024 · 1 comment
Closed
Labels
C-bug Category: bug. Something is wrong. This is bad!

Comments

@linyihai
Copy link
Contributor

linyihai commented Dec 2, 2024

Version

hyper version is 1.5.0, use default feature.

Platform

Linux linlaptop 5.15.167.4-microsoft-standard-WSL2 #1 SMP Tue Nov 5 00:21:55 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Description

Although rustc-version with 1.63 defined in Cargo.toml, the below build failed:

 cargo +1.63-x86_64-unknown-linux-gnu check
warning: unused manifest key: lints
error: package `tokio v1.41.1` cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.63.0

Should we bump rust-version to rustc 1.70 ?

cargo +1.70-x86_64-unknown-linux-gnu check
warning: unused manifest key: lints
    Checking bytes v1.8.0
    Checking fnv v1.0.7
    Checking itoa v1.0.11
    Checking pin-project-lite v0.2.15
    Checking tokio v1.41.1
    Checking http v1.1.0
    Checking http-body v1.0.1
    Checking hyper v1.5.0 (/root/workspace/hyper)
    Finished dev [unoptimized + debuginfo] target(s) in 1.47s
@linyihai linyihai added the C-bug Category: bug. Something is wrong. This is bad! label Dec 2, 2024
@seanmonstar
Copy link
Member

No, we don't need to. hyper itself doesn't need a newer compiler, and can work with older versions of Tokio that support Rust 1.63. That's why we pin Tokio in the MSRV CI job.

@seanmonstar seanmonstar closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug. Something is wrong. This is bad!
Projects
None yet
Development

No branches or pull requests

2 participants