Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyper-util is incompatible with tower 0.5 #3757

Closed
kanpov opened this issue Sep 22, 2024 · 1 comment · Fixed by hyperium/hyper-util#151
Closed

Hyper-util is incompatible with tower 0.5 #3757

kanpov opened this issue Sep 22, 2024 · 1 comment · Fixed by hyperium/hyper-util#151
Assignees
@seanmonstar
Labels
A-dependencies Area: library dependencies. C-chore Category: chore. a general chore or maintenance task. E-easy Effort: easy. A task that would be a great starting point for a new contributor. K-hyper-util Crate: hyper-util

Comments

@kanpov
Copy link

kanpov commented Sep 22, 2024

Version
List the version(s) of hyper, and any relevant hyper dependency (such as h2 if this is related to HTTP/2).
Hyper 1.4.1
Hyper-util 0.1.8

Platform
The output of uname -a (UNIX), or version and 32 or 64-bit (Windows)
Linux localhost.localdomain 6.10.11-1-default #1 SMP PREEMPT_DYNAMIC Thu Sep 19 07:33:24 UTC 2024 (bd33620) x86_64 x86_64 x86_64 GNU/Linux

Description
tower-http and axum have all migrated to tower 0.5.x on their stable releases, yet hyper-util which is a semi-mandatory dependency of axum is stuck on tower 0.4.x, resulting in two versions of tower needing to be pulled in for every axum project.
@kanpov kanpov added the C-bug Category: bug. Something is wrong. This is bad! label Sep 22, 2024
@seanmonstar seanmonstar mentioned this issue Sep 23, 2024
Merged
@Catwoman08
Copy link

Thank you for reporting this. That should be easy to do @seanmonstar already has a PR up that will address this.

@Catwoman08 Catwoman08 added C-chore Category: chore. a general chore or maintenance task. A-dependencies Area: library dependencies. E-easy Effort: easy. A task that would be a great starting point for a new contributor. K-hyper-util Crate: hyper-util and removed C-bug Category: bug. Something is wrong. This is bad! labels Sep 24, 2024
@seanmonstar seanmonstar self-assigned this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanmonstar seanmonstar

Labels
A-dependencies Area: library dependencies. C-chore Category: chore. a general chore or maintenance task. E-easy Effort: easy. A task that would be a great starting point for a new contributor. K-hyper-util Crate: hyper-util
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove tower dep by vendoring Oneshot hyperium/hyper-util
3 participants
@seanmonstar @kanpov @Catwoman08