Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems strange to have this crate separated from hyper. #31

Closed
thedodd opened this issue Sep 16, 2018 · 1 comment
Closed

Seems strange to have this crate separated from hyper. #31

thedodd opened this issue Sep 16, 2018 · 1 comment

Comments

@thedodd
Copy link

thedodd commented Sep 16, 2018

IMHO, having this crate separated out from hyper doesn't really accomplish too much other than adding additional time and effort to basic usage. Defaulting to https support, but allowing a user to opt out, would seem to be a far more logical (and secure) pattern.

  1. if someone wants to use different connectors, they would certainly still be able to, and perhaps that is when they would opt out of the "https" feature.
  2. adoption of hyper would be faster and easier. E.G., I found out that I needed a different support crate for Hyper TLS when using the client and it failed saying that only http was supported.
    I know that there is info on the website, but I did not see it in the docs, and I didn't read the website until later.
  3. batteries included seems to be a big part of rust. HTTPS isn't even a battery though. It is standard these days.

All in all, thank you @seanmonstar and everyone else who has contributed to the Hyper ecosystem. It is certainly foundational to the Rust web ecosystem. I hope my feedback here is constructive and valuable.

@seanmonstar
Copy link
Member

For reference, the decision is written up in this issue: hyperium/hyper#985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants