Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility and missing features #4

Open
husseinalhammad opened this issue Aug 3, 2022 · 5 comments
Open

Compatibility and missing features #4

husseinalhammad opened this issue Aug 3, 2022 · 5 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@husseinalhammad
Copy link
Owner

It's been a while since I used this myself. I would like to check its compatibility with Font Awesome 6 when I have the time.

I am also interested to know which FA features cannot be used with FontAwesomeSVG-PHP right now.

@MaximVanhove
Copy link

We use your package all the time! I can check compability and PR any changes if you're open for it?

@husseinalhammad
Copy link
Owner Author

That would be very helpful! Thanks @MaximVanhove.

It may be worth compiling a list of what needs to be checked. There is quite a bit of features listed on the official docs:
https://fontawesome.com/docs/web/

@husseinalhammad husseinalhammad added help wanted Extra attention is needed question Further information is requested labels Aug 17, 2022
@MaximVanhove
Copy link

@husseinalhammad Can I add some phpunit tests to make sure the code is compatible with Fontawesome 5 and Fontawesome 6?

@husseinalhammad
Copy link
Owner Author

Absolutely! That would be much appreciated, @MaximVanhove. Go for it!

Related: #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants