From bcbfee418884ef234f36d8897254dd7739716880 Mon Sep 17 00:00:00 2001 From: miu Date: Thu, 7 Apr 2016 13:45:38 -0700 Subject: [PATCH] =?UTF-8?q?Revert=20of=20Reset=20NACK/ACK=20list=20when=20?= =?UTF-8?q?parsing=20a=20new=20RTCP=20packet.=20The=20NACK/ACK=20frames/pa?= =?UTF-8?q?ckets=20list=20need=20to=20be=20res=E2=80=A6=20(patchset=20#1?= =?UTF-8?q?=20id:1=20of=20https://codereview.chromium.org/1875433002/=20)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reason for revert: This change needs to be slightly modified since M50 does not have the |received_later_frames| set. Original issue's description: > Reset NACK/ACK list when parsing a new RTCP packet. The NACK/ACK frames/packets list need to be reset before parsing each RTCP packet as the parser is shared by all RTCP packets on sender side. This caused the performance regression and potentially video freezing as well. > > BUG=600527 > > Review URL: https://codereview.chromium.org/1853253003 > > Cr-Commit-Position: refs/heads/master@{#385046} > (cherry picked from commit 411ea14c10f64b67a25985619583a5331e724d57) > > Committed: https://chromium.googlesource.com/chromium/src/+/e877754f597c1c2fa8ff411be0c2c6ade0cd6c9f TBR=xjz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=600527 Review URL: https://codereview.chromium.org/1869163002 Cr-Commit-Position: refs/branch-heads/2661@{#512} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} --- media/cast/net/rtcp/rtcp_utility.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/media/cast/net/rtcp/rtcp_utility.cc b/media/cast/net/rtcp/rtcp_utility.cc index 33ac1b41c6402..74af3a04fb45a 100644 --- a/media/cast/net/rtcp/rtcp_utility.cc +++ b/media/cast/net/rtcp/rtcp_utility.cc @@ -291,8 +291,6 @@ bool RtcpParser::ParseFeedbackCommon(base::BigEndianReader* reader, // Please note, this frame_id is still only 8-bit! cast_message_.ack_frame_id = last_frame_id; - cast_message_.missing_frames_and_packets.clear(); - cast_message_.received_later_frames.clear(); for (size_t i = 0; i < number_of_lost_fields; i++) { uint8_t frame_id; uint16_t packet_id;