Skip to content

Image links are broken in Gallery components #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shadyvb opened this issue Apr 10, 2020 · 2 comments · May be fixed by #423
Open

Image links are broken in Gallery components #422

shadyvb opened this issue Apr 10, 2020 · 2 comments · May be fixed by #423
Labels
Bug Low priority

Comments

@shadyvb
Copy link

shadyvb commented Apr 10, 2020

Issue Description

Clicking images in gallery components leads to an error, since H2 seems to be treating them as post links. ( Given that 'Link to' option is set to 'Media file' ).
image

Steps to reproduce:

  • Add a new gallery with one or more images
  • Set 'Link to' to 'Media file'
  • Preview the article
  • Click one of the images

Expected Result:

  • I see the image ( open in a new tab, since we don't have lightbox-like components )
@shadyvb shadyvb linked a pull request Apr 10, 2020 that will close this issue
Open
@CoreyBenefiel
Copy link

@shadyvb Do you have an example post we can reference?

@CoreyBenefiel
Copy link

2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce ImageLink component to open image links in a Modal humanmade/h2
2 participants
@shadyvb @CoreyBenefiel