From ebb9ff517f1d0caeca6ad9277ce56398302062fb Mon Sep 17 00:00:00 2001 From: Di Xiao Date: Sat, 25 Jan 2025 07:55:15 +0800 Subject: [PATCH] Fix ubuntu aarch64 build (#152) Build on ubuntu-22.04, aarch64 has been failing since [this commit](https://github.com/huggingface/xet-core/commit/8f52fade9876710d1c2ecd771f407d640b1c4ea0), looks like jsonwebtoken introduced ring and the ARM assembler doesn't like it: [CI](https://github.com/huggingface/xet-core/actions/runs/12895273205/job/35955801283#step:4:812). A [comment](https://github.com/briansmith/ring/issues/1728#issuecomment-1758180655) under a ring repo related issue mentioned that "[manylinux_2_28](https://github.com/rust-cross/manylinux-cross#manylinux_2_28) based on GCC 7.5.0 works fine". --- .github/workflows/release.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index e3400ab6..80739e0d 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -27,9 +27,11 @@ jobs: platform: - runner: ubuntu-22.04 target: x86_64 + manylinux: auto features: "--features openssl_vendored" - runner: ubuntu-22.04 target: aarch64 + manylinux: manylinux_2_28 features: "--features openssl_vendored" steps: - uses: actions/checkout@v4 @@ -42,7 +44,7 @@ jobs: target: ${{ matrix.platform.target }} args: --release ${{ matrix.platform.features }} --out dist sccache: 'true' - manylinux: auto + manylinux: ${{ matrix.platform.manylinux }} working-directory: hf_xet before-script-linux: | if command -v apt-get &> /dev/null; then