You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The TensorFlow implementation of the MPNet model currently has no integration tests. This is problematic as the behavior can diverge without being noticed.
The test must be marked as slow using the @slow decorator, so as to be run daily, and not on every commit of every branch/pull request of this repository.
The test must be decorated with the @require_tf decorator so as to only be run in environments using PyTorch.
A single test is necessary. If you feel like implementing multiple of these, then sharing the same checkpoint would be ideal so as to reduce download time.
The text was updated successfully, but these errors were encountered:
The TensorFlow implementation of the MPNet model currently has no integration tests. This is problematic as the behavior can diverge without being noticed.
The test_modeling_tf_mpnet.py file should be updated to include integration testing.
An example of a good modeling integration test is visible in the test_modeling_tf_bert.py#L365-L387 file:
transformers/tests/test_modeling_tf_bert.py
Lines 365 to 387 in 1809de5
Some additional tips:
@slow
decorator, so as to be run daily, and not on every commit of every branch/pull request of this repository.@require_tf
decorator so as to only be run in environments using PyTorch.The text was updated successfully, but these errors were encountered: