Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing None verification in the CLM language modeling example #9927

Closed
Aunsiels opened this issue Feb 1, 2021 · 1 comment · Fixed by #9977
Closed

Missing None verification in the CLM language modeling example #9927

Aunsiels opened this issue Feb 1, 2021 · 1 comment · Fixed by #9977

Comments

@Aunsiels
Copy link

Aunsiels commented Feb 1, 2021

Here:

extension = data_args.train_file.split(".")[-1]
, data_args.train_file can be None (as it is checked some lines above). Therefore, there should be a check to see if it is the case or not.

@patil-suraj
Copy link
Contributor

HI @Aunsiels you are right, thanks! Feel free to open PR to fix it :)

If train_file is None it should use validation_file to get the extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants