Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mimic adamw_torch_4bit and have adamw_torch_8bit #34893

Closed
fzyzcjy opened this issue Nov 23, 2024 · 6 comments · Fixed by #34993
Closed

Mimic adamw_torch_4bit and have adamw_torch_8bit #34893

fzyzcjy opened this issue Nov 23, 2024 · 6 comments · Fixed by #34993
Labels
Feature request Request for a new feature

Comments

@fzyzcjy
Copy link
Contributor

fzyzcjy commented Nov 23, 2024

Feature request

Hi thanks for the lib! Currently there is adamw_torch_4bit, but I hope to mimic it to have a adamw_torch_8bit that uses 8bit torchao adamw.

The reason is that, I would like to use deepspeed cpu offload for the optimizer, and also use 8bit adamw. However, the 8bit one in current hf transformers does not support cpu, so I need to use the torchao one.

Motivation

Your contribution

yes, willing to PR

@fzyzcjy fzyzcjy added the Feature request Request for a new feature label Nov 23, 2024
@fzyzcjy fzyzcjy changed the title Mimic adamw_torch_4bit and have adamw_torch_8bit (Willing to PR if this is acceptable) Mimic adamw_torch_4bit and have adamw_torch_8bit Nov 24, 2024
@Rocketknight1
Copy link
Member

cc @muellerzr for deepspeed/accelerate!

@muellerzr
Copy link
Contributor

A PR for this would be great 🤗 cc @SunMarc

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Nov 25, 2024

Thanks! I will do that later.

@SunMarc
Copy link
Member

SunMarc commented Nov 25, 2024

Feel free to add it ! Let me know if you need any help

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Nov 25, 2024

Thanks! I will firstly mimic the 4bit one and see whether it works.

@fzyzcjy fzyzcjy mentioned this issue Nov 28, 2024
5 tasks
@fzyzcjy fzyzcjy changed the title (Willing to PR if this is acceptable) Mimic adamw_torch_4bit and have adamw_torch_8bit Mimic adamw_torch_4bit and have adamw_torch_8bit Nov 28, 2024
@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Nov 28, 2024

PR created: #34993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants