-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonize warnings/errors/documentation related to file size limit #995
Comments
Ping @julien-c @Pierrci @SBrandeis for moon-landing-related questions. |
To clarify a bit all the different numbers:
I would say yes for 3., for 4. I would say why not if it's gonna be useful to downstream libs, but I will let others chime in :) Also cc @Kakulukian @allendorf for information |
Also yes from me for 3. (inside For 4. i think it's on the downstream libraries to do it, because they have more context to do it in a better way. For instance cc @LysandreJik @sgugger too |
For 3, I think |
Indeed, we had started something with @muellerzr for 4., but in the end having framework-specific approaches made much more sense. I'd focus on 3. and do 4. only if we see extensive requests. As long as the page in 3. is heavily referenced from |
Done as part of #1565. |
In general, file size limit is not made very clear for the user especially when uploading a file to the hub via HTTP endpoint. Discussion started as part of #847 on whether we should throw an explicit error and provide guidance when a file is too big to be uploaded (see comments #847 (comment), #847 (comment), #847 (comment), #847 (comment) and #847 (comment)).
In the documentation, we also mention a limit of 50GB in
upload_file
and a limit of 5GB before using LFS in general.To be discussed:
a. A possibility I see here is to raise a
ValueError
if file size is above 30GB (hard-limit) and raise a warning if file size is above 10GB (soft-limit).a. I would propose to have a dedicated page/section in the documentation and each method
create_commit
,upload_file
,upload_folder
,push_to_hub
,... could refer to it.The text was updated successfully, but these errors were encountered: