Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node fetch ignore HTTP_PROXY settings. #145

Open
runningrunning opened this issue Feb 3, 2025 · 3 comments
Open

Node fetch ignore HTTP_PROXY settings. #145

runningrunning opened this issue Feb 3, 2025 · 3 comments

Comments

@runningrunning
Copy link

runningrunning commented Feb 3, 2025

The commit is dda5ccd
It's mentioned in nodejs/node#42814 and nodejs/node#43187.

@runningrunning runningrunning changed the title https://github.com/http-tests/cache-tests/commit/dda5ccd194a5d768163a82ad62bd978be691bf58 will ignore HTTP_PROXY settings. dda5ccd194a5d768163a82ad62bd978be691bf58 will ignore HTTP_PROXY settings. Feb 3, 2025
@runningrunning runningrunning changed the title dda5ccd194a5d768163a82ad62bd978be691bf58 will ignore HTTP_PROXY settings. Node fetch ignore HTTP_PROXY settings. Feb 3, 2025
@mnot
Copy link
Collaborator

mnot commented Feb 3, 2025

Do you need to test a forward proxy? If not I'm inclined to just remove it from the docs for now.

@runningrunning
Copy link
Author

Well, I can workaround by manually revert this commit.

TBH, this repo help me a lot while developping the forward proxy, even from complementary purpose, I would suggest to at least mentioned it can be fixed or hotpatched through these two links in nodejs repo.

And I don't think it's only useful for forward proxy, it maybe needed to bypass network limitation. Or how does the nginx been tested in the benchmark?

@runningrunning
Copy link
Author

Since it's an issue in node already, maybe the doc can be just marked as a dependency. Or mentioned if it's needed, just manually revert this commit and wait until it's fixed on upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants