Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong ignore indicator with nested ignore rules #85

Closed
manuakasam opened this issue Mar 2, 2015 · 7 comments
Closed

Wrong ignore indicator with nested ignore rules #85

manuakasam opened this issue Mar 2, 2015 · 7 comments
Labels

Comments

@manuakasam
Copy link

Imagine the following directory structore

/foo
/foo/bar
/foo/bar/baz
/foo/ball

Assuming these contents for mutliple gitignores

.gitignore

/*
!foo/

/foo/.gitignore

/*
!.gitignore
!bar/

/foo/bar.gitignore

/*
!.gitignore
!baz/

Assuming the above ruling, all sub-directories under foo would be highlighted as ignored. Going by git itself however, the excluded rules match appropriately and files from /foo/bar/ would be added to the index without any problems.

@hsz hsz added the bug label Mar 2, 2015
@serwizz
Copy link

serwizz commented Mar 2, 2015

Hi, I have same issue. I ignore some folders and file in foo folder. My .gitignore file is

!/foo
/foo/*
!/foo/templates
/foo/templates/bad_template

but plugin painted all in foo folder in grey

@wlf10
Copy link

wlf10 commented Mar 3, 2015

+1

@hsz
Copy link
Member

hsz commented Mar 3, 2015

Thank you guys for reporting it. I'll fix it soon.

@hsz
Copy link
Member

hsz commented Mar 3, 2015

Fixed with release v1.0.1.

Please confirm if everything is fine.

@manuakasam
Copy link
Author

Hey Jakub,

first off: thanks for the really fast reply / fix (attempt).

As the word inclines however it appears that now the plugin is completely
broken as it doesn't color anything anymore :S
Tested on EAP, 8.0.2 and 8.0.3

It doesn't even work for top level files in a new project.

Jakub Chrzanowski [email protected] schrieb am Mi., 4. März 2015
um 00:00 Uhr:

Fixed with release v1.0.1.

Please confirm if everything is fine.


Reply to this email directly or view it on GitHub
#85 (comment).

hsz added a commit that referenced this issue Mar 4, 2015
@hsz
Copy link
Member

hsz commented Apr 13, 2015

Please verify if everything is fine with release v1.1.

@manuakasam
Copy link
Author

Hey again Jakub,

the 1.1 release seems to have fixed the issue. Great work :)

/Sam

Jakub Chrzanowski [email protected] schrieb am Mo., 13. Apr. 2015
um 07:20 Uhr:

Please verify if everything is fine with release v1.1.


Reply to this email directly or view it on GitHub
#85 (comment).

@hsz hsz closed this as completed Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants