Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not parse files contained within directories marked as ignored. #125

Closed
matt-usurp opened this issue May 14, 2015 · 3 comments
Closed
Labels
Milestone

Comments

@matt-usurp
Copy link

When opening a project where a dependency manager is available (PHP and Composer) the ignore files are indexed within the dependency directory that is marked as ignored by the projects root ignore.

In more detail

You have a project such as Symfony 2 using PHP's community based dependency manager composer. These files are downloaded to a directory within your project which is then ignored using (git) ignore files. Using Ideas "exclude directory" feature is not viable here as the reason you have the dependencies locally is so you have code completion. Without the ignore plugin this works fine. The issue arises when the ignore plugin indexes all the ignore files in the project including the ones contained in directories that are marked within other ignore files.

A side note; I am using PHPStorm 8.0.3 with the latest version of the plugin available.

Example

contents of .gitignore

vendor
composer.phar

The following messages are shown

Ignore rules indexing
- vendor/symfony/http-foundation/.ignore
- vendor/symfony/framework/.ignore
- vendor/symfony/blah/.ignore
- and so on

The expected behaviour is that the root ignore file is parsed and then the directory tree is traversed from there. In this case the ignore file would see that vendor is ignored and not bother indexing the 25+ other ignore files contained inside.

There is a similar ticket #78 which I thought was going to cover this but it is marked as closed and the conversation within it was not as expected.

@matt-usurp matt-usurp changed the title Not parsing ignored files when "indexing". Do not parse files contained within directories marked as ignored. May 14, 2015
@matt-usurp
Copy link
Author

The PHPStorm plugin manager says 1.1.2

On 14 May 2015 at 11:10, Jakub Chrzanowski [email protected] wrote:

@matt-usurp https://github.com/matt-usurp Thank you for reporting.

Which version of plugin do you use ?


Reply to this email directly or view it on GitHub
#125 (comment).

@hsz hsz added the bug label Jun 2, 2015
hsz added a commit that referenced this issue Jun 2, 2015
@hsz hsz added this to the 1.1.3 milestone Jun 2, 2015
@hsz hsz closed this as completed Jun 2, 2015
@hsz
Copy link
Member

hsz commented Jun 2, 2015

@matt-usurp Fix has been already released with version v1.1.3 and is available for download.

@matt-usurp
Copy link
Author

@hsz Thanks! Project loading times have been cut to a fraction. Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants