Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shape] pass d3 accessor arguments to the x and y props of LinePath, AreaClosed, and LinePath #295 #309

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

davidandrus
Copy link

See #295 for an explanation of the issue and some related discussion about the components affected.

🚀 Enhancements

  • Updating accessors to pass all the arguments from D3 for LinePath, AreaClosed, and Area.
  • Updating documentation for LinePath and AreaClosed to reflect the above changes.
    Note: Area has no current documentation to update.

@davidandrus davidandrus changed the title [shape] pass d3 accessor arguments to the x and y props of LinePath, AreaClosed, and LinePath #295 [shape] pass d3 accessor arguments to the x and y props of LinePath, AreaClosed, and LinePath #295 🚀 Jun 13, 2018
@davidandrus davidandrus changed the title [shape] pass d3 accessor arguments to the x and y props of LinePath, AreaClosed, and LinePath #295 🚀 [shape] pass d3 accessor arguments to the x and y props of LinePath, AreaClosed, and LinePath #295 Jun 13, 2018
@hshoff hshoff added this to the v0.0.166 milestone Jun 13, 2018
Copy link
Member

@hshoff hshoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contribution!

@hshoff hshoff merged commit d88c5ed into airbnb:master Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants