Brave Story a black triangle

[daniel229]

Also happen in 0.9.9.1-54-gdfbb0bd and 0.9.6

Ge debugger

other tabs
https://gist.github.com/daniel229/9e19640f86e74a082b46

Savestate
http://1drv.ms/1TtExKp

[unknownbrackets]

I tried disabling each test in a row, and it didn't help. Basically these are supposed to be the tops of the walls. It's drawing a near-black color.

My suspicion is that it's meant to be clipped, but isn't being. It's drawing 843 vertices with varying points, so it's hard to determine the exact problem points. Even with all tests disabled, it doesn't actually draw everywhere the points highlight (per the vertex preview.) Assuming this isn't a bug in the vertex preview, I assume it's culling or clipping or something.

Hmm.

-[Unknown]

[daniel229]

Also a gamesave here.
talk to rhis people,and then it take you to the world,then go to east.

Rename jpg to 7z.

[unknownbrackets]

I'm marking this as depth related, I think it is.

Viewport: 32750.0 +- 32750.0 => [0, 65500]
Minmaxz: [0, 65500]
Clipping: OFF
Stencil test: ALWAYS (REPLACE 00)
Alpha test: > 0x80 (no vert color, so this seems based on lighting which has fixed 0xff alpha.)
Depth test: src >= dst

If I expand the projected z by 1.1f, the triangle shrinks. 1.2f is enough to make it go away entirely. I'm not sure... maybe this means it isn't depth related exactly, and is some other kind of clipping issue? It does have culling enabled.

The area in question has depth values around ~21000 prior to the artifact. After the draw, the artifact's area has depth values around ~64851. I guess it could even be a CPU rounding issue in generating these coordinates... the very corner of the artifact has a depth of 65498, just barely below clipping.... but near the top right it's as low as 60971.

-[Unknown]

[unknownbrackets]

So, putting this in the vertex shader, which is just a quick hack, makes the triangle go away:

        WRITE(p, "vec2 test123 = gl_Position.xy / gl_Position.w;");
        WRITE(p, "if (test123.x < -4.0 || test123.x > 4.0 || test123.y < -4.0 || test123.y > 4.0) { gl_Position.xyz = vec3(1000000.0 * -1000000.0 * gl_Position.w); }");

I think there's a good chance this issue is that vertices outside the 4096x4096 drawing space are supposed to be completely culled.

-[Unknown]