Vulkan: Be more restrictive about hardware texture upscaling on "slow" GPUs #15238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies the same rules as for software upscaling in this case. Should fix the stutters seen in #15109
|
This improve? #15109 (comment) |
|
Yes! |
|
@Gamemulatorer if it doesn't improve for you, let me know your device's GPU and Android version. I'll make the checks more accurate. |
Still the same the game still stuttering using ppsspp v1.12.3-479, btw my phone gpu is Mali-G52 MC2 android 11. |
|
OK thank you, I'll get it fixed. |
hrydgard
added a commit
that referenced
this pull request
Dec 18, 2021
|
Thanks!!! |
|
The newest builds from v1.12.3-479 and up are hanging and freezing my phone
at the startup screen
…On Sat, Dec 18, 2021, 20:42 Henrik Rydgård ***@***.***> wrote:
OK thank you, I'll get it fixed.
—
Reply to this email directly, view it on GitHub
<#15238 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASDWOXOSIQD7Q3B67ELRNT3URTW5BANCNFSM5KHFVMOQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
@FrenchPrick Wait, really? What phone do you have? |
|
According to his comment from melonds android github. |
|
Actually it's Android 11.
…On Sun, Dec 19, 2021, 15:14 AEZ YT ***@***.***> wrote:
According to his comment from melonds android github.
[image: IMG_20211219_231320]
<https://user-images.githubusercontent.com/37603562/146680219-647ed627-c8e6-49d8-891f-455377049c21.jpg>
Android 10 Mali-G71
—
Reply to this email directly, view it on GitHub
<#15238 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASDWOXI5RMCTTGBSV4ZNSILURXZGXANCNFSM5KHFVMOQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Still crashing in build 482? |
|
Sorry for the late reply but it's no longer crashing for me the latest
build has fixed the problem.
…On Sun, Dec 19, 2021, 20:00 Henrik Rydgård ***@***.***> wrote:
Still crashing in build 482?
—
Reply to this email directly, view it on GitHub
<#15238 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASDWOXJR4C4XWKP7AQFWRCTURY2XFANCNFSM5KHFVMOQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the same rules as for software upscaling in this case. Uses some super crude and inaccurate heuristics to identify potentially slow GPUs (Android < 11, Qualcomm or Mali), but it doesn't matter much.
Should fix the stutters seen in #15109