Close buffers not included in opts.get_bufnrs() #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
Isn't this problematic when our With the example of visible buffers, if in a tab, I get completions(with indexing), I switch to another tab, I get completion(with indexing), I go back to previous tab: I'll need to re-index buffers? |
|
When and how is it context dependent? It looks like the original code assumes a static mapping of buffer numbers to open buffers, so mine does as well. |
|
Certainly, if get_bufnrs changes the return value depending on the context, the deleted buffer will be re-indexed, so it seems to affect the CPU. google translated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #55
An excess of indexed buffers can cause performance issues with buffer completion. If the user tries to limit the number of indexed buffers using
get_bufnrs(), the old buffers are still retained when not specified in that function until they are wiped out. The workaround as discussed in #40 is to wipeout the old buffers, which is the only way to guarantee that indexing stops.This PR calls
close()on any buffers previously indexed but not returned in a subsequentget_bufnrs()call.