Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream append/prepend can produce duplicates if the template element is a form #879

Closed
ethancrawford opened this issue Feb 23, 2023 · 1 comment · Fixed by #880 · May be fixed by #1037
Closed

Stream append/prepend can produce duplicates if the template element is a form #879

ethancrawford opened this issue Feb 23, 2023 · 1 comment · Fixed by #880 · May be fixed by #1037

Comments

@ethancrawford
Copy link
Contributor

Hi! So, I noticed that if you try to append or prepend a form which contains a child form control with the name 'id', (such as in this minimal-ish example):

<form id="myform">
  <input name="id">
</form>

...then the 'old' form is not removed when the new one is appended/prepended.
(Since myform.id will then refer to the named child control, not the form's id attribute, and the id match created previously to remove duplicates fails).

@seanpdoyle
Copy link
Contributor

Thank you for opening this issue.

I've opened #1037 to deal with a similar collision with regard to the [action] attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants