BUG: The turbo:frame-load event is fired before window.location is updated when using turbo-action="advance"

[rathboma]

To perform some actions when the turbo frame has finished loading and the URL has changed is currently not possible.

When turbo-frame-load fires, the window.location has not yet been updated, so checking window.location.* still gives the old URL.

Steps to reproduce:

function logEvent(event) {
  console.log("comparing src vs window:", event.target.src, window.location.href)
)

document.documentElement.addEventListener('turbo:frame-load', logEvent)

[seanpdoyle]

Thank you for opening this issue!

Is this potentially a duplicate of #617, which might be resolved by #618? #618 is merged, but not yet released.

[rathboma]

I checked out the issue. It's similar but not exactly the same -- regardless of whether you change location before or after rendering, certainly it should be changed before turbo:frame-load fires.

That fix might fix it, I have a hard time knowing -- does that change the behavior to address #617? If so it probably will

[seanpdoyle]

I've just tested this locally to confirm that it has been resolved by #618.

It's covered by a test that makes the same check during the turbo:frame-render event, which is dispatched before the turbo:frame-load event.