-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start mapping button is not functional on mobile website and PWA #1393
Comments
Hmm, is this dev stage or prod? |
It was replicable on all servers. Seems like this issue is there when users aren't logged in. |
For now can we allow locking and unlocking without log in? @Sujanadh |
okay but how do we track who updated the status? |
Good question! We either don't provide the info of who updated & allow unauthenticated access, or provide a basic API for a simple type of auth. We talked about email based auth being an option, but it would be very nice if we don't even need an email address! What do you think about us having a temporary login token option, valid for one week? The token would have restricted access to only view projects and update task status. The user could provide their name in an input field, and the API will generate and return a token in a cookie. Open to other ideas too! |
It sounds good to me |
what about using jwt ? or are we saving token in database for basic authentication? |
Yep we should! OSM login is actually JWT based login, but implemented to never expire 😅 I was thinking an easy approach could be to just use the We include the token from that user as an environment variable in the container startup. Then for the 'temp login token' functionality, we could just create a cookie with that value that expires in a week. With this approach the only thing I didn't work out is handling private projects, as we need to link an actual user to the project for mapper permissions to work. Open to ideas! |
saving user info wont be possible unless we create a separate table for that. if it is temporary approach then we don't have to think much on saving user data. Using svcfmtm might be good as you mentioned. |
I think it's the way to go for now then 👍 We can work out how to link to private projects later. One idea:
|
I am unable to test this since. the project area is not visible in mobile. Record_2024-04-24-13-24-20.mp4 |
This should be testable now for release 2023.03 👍 |
Describe the bug
I am unable to click on start mapping of any task on mobile. However it works on laptop.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The status of task should be changed to locked for mapping.
Screenshots
If applicable, add screenshots to help explain your problem.
Smartphone (please complete the following information):
The text was updated successfully, but these errors were encountered: