From 9cb1e1ca2a9ccbe6ce1296230ceebced5a058153 Mon Sep 17 00:00:00 2001 From: adel-ak Date: Sun, 19 Jan 2025 14:24:12 +0300 Subject: [PATCH 1/4] node-ws: Added missing WSContext raw type --- packages/node-ws/src/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/node-ws/src/index.ts b/packages/node-ws/src/index.ts index b7d6f5c83..29e1257a3 100644 --- a/packages/node-ws/src/index.ts +++ b/packages/node-ws/src/index.ts @@ -8,7 +8,7 @@ import type { Http2SecureServer, Http2Server } from 'node:http2' import { CloseEvent } from './events' export interface NodeWebSocket { - upgradeWebSocket: UpgradeWebSocket + upgradeWebSocket: UpgradeWebSocket injectWebSocket(server: Server | Http2Server | Http2SecureServer): void } export interface NodeWebSocketInit { @@ -73,7 +73,7 @@ export const createNodeWebSocket = (init: NodeWebSocketInit): NodeWebSocket => { const events = await createEvents(c) const ws = await nodeUpgradeWebSocket(c.env.incoming) - const ctx: WSContext = { + const ctx: WSContext = { binaryType: 'arraybuffer', close(code, reason) { ws.close(code, reason) From ef00f36b8f88d8e2b355f61450a09818c3fba664 Mon Sep 17 00:00:00 2001 From: adel-ak Date: Mon, 20 Jan 2025 14:01:15 +0300 Subject: [PATCH 2/4] Updated hono version and added it as peer dependencies --- packages/node-ws/package.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/node-ws/package.json b/packages/node-ws/package.json index f11565ae3..825820e23 100644 --- a/packages/node-ws/package.json +++ b/packages/node-ws/package.json @@ -34,7 +34,7 @@ "devDependencies": { "@hono/node-server": "^1.11.1", "@types/ws": "^8", - "hono": "^4.2.9", + "hono": "^4.6.17", "tsup": "^8.0.1", "vitest": "^1.0.4" }, @@ -42,7 +42,8 @@ "ws": "^8.17.0" }, "peerDependencies": { - "@hono/node-server": "^1.11.1" + "@hono/node-server": "^1.11.1", + "hono": "^4.6.17" }, "engines": { "node": ">=18.14.1" From 82483f616f2629b3dfff53039d7199553b68a346 Mon Sep 17 00:00:00 2001 From: Yusuke Wada Date: Tue, 21 Jan 2025 18:34:34 +0900 Subject: [PATCH 3/4] update `package.json` and the lock file --- packages/node-ws/package.json | 4 ++-- yarn.lock | 17 +++++++++-------- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/packages/node-ws/package.json b/packages/node-ws/package.json index 825820e23..1d068a668 100644 --- a/packages/node-ws/package.json +++ b/packages/node-ws/package.json @@ -34,7 +34,7 @@ "devDependencies": { "@hono/node-server": "^1.11.1", "@types/ws": "^8", - "hono": "^4.6.17", + "hono": "^4.6.0", "tsup": "^8.0.1", "vitest": "^1.0.4" }, @@ -43,7 +43,7 @@ }, "peerDependencies": { "@hono/node-server": "^1.11.1", - "hono": "^4.6.17" + "hono": "^4.6.0" }, "engines": { "node": ">=18.14.1" diff --git a/yarn.lock b/yarn.lock index 3f99fdbd2..d47d9b799 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2779,12 +2779,13 @@ __metadata: dependencies: "@hono/node-server": "npm:^1.11.1" "@types/ws": "npm:^8" - hono: "npm:^4.2.9" + hono: "npm:^4.6.0" tsup: "npm:^8.0.1" vitest: "npm:^1.0.4" ws: "npm:^8.17.0" peerDependencies: "@hono/node-server": ^1.11.1 + hono: ^4.6.0 languageName: unknown linkType: soft @@ -11818,13 +11819,6 @@ __metadata: languageName: node linkType: hard -"hono@npm:^4.2.9": - version: 4.3.3 - resolution: "hono@npm:4.3.3" - checksum: 2e02a563ab8461a56a97b59b1c31fd002179999a0323b3a44cbf8b69b92ad35cc8f38ba26a88b64caa71e2c1c39a1454d84473ed0c69f4e9573e7b3b064e0f58 - languageName: node - linkType: hard - "hono@npm:^4.3.6": version: 4.3.6 resolution: "hono@npm:4.3.6" @@ -11867,6 +11861,13 @@ __metadata: languageName: node linkType: hard +"hono@npm:^4.6.0": + version: 4.6.17 + resolution: "hono@npm:4.6.17" + checksum: a951eb705841282c16a98ff0b45fb58d2325f945e839ec43c820c29dd380092382781a1fd4590d809a9a0ec9f4df6db738a06bf58c6ce2c279879374d070e2ab + languageName: node + linkType: hard + "hono@npm:^4.6.10": version: 4.6.10 resolution: "hono@npm:4.6.10" From f6a8a55a331db6c40f6c10fb2e8c81b84c5ab3a5 Mon Sep 17 00:00:00 2001 From: Yusuke Wada Date: Tue, 21 Jan 2025 18:35:22 +0900 Subject: [PATCH 4/4] add changeset --- .changeset/metal-kiwis-doubt.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/metal-kiwis-doubt.md diff --git a/.changeset/metal-kiwis-doubt.md b/.changeset/metal-kiwis-doubt.md new file mode 100644 index 000000000..66ce1db9d --- /dev/null +++ b/.changeset/metal-kiwis-doubt.md @@ -0,0 +1,5 @@ +--- +'@hono/node-ws': patch +--- + +fix: Added missing WSContext raw type