Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve score of JSR symbol #2861

Open
fzn0x opened this issue May 29, 2024 · 8 comments
Open

Improve score of JSR symbol #2861

fzn0x opened this issue May 29, 2024 · 8 comments
Labels
enhancement New feature or request.

Comments

@fzn0x
Copy link
Contributor

fzn0x commented May 29, 2024

What is the feature you are proposing?

Screenshot 2024-05-30 064618

Reference: https://jsr.io/docs/writing-docs#symbol-documentation

Now (when this issue was created) we only have 19% of the code documented, we can start with the public methods first before focusing on the private ones. In future, after we done with the JSR symbol, we can continously improve the code documentation.

@fzn0x fzn0x added the enhancement New feature or request. label May 29, 2024
@EdamAme-x
Copy link
Contributor

Progress
#2836

@fzn0x
Copy link
Contributor Author

fzn0x commented May 30, 2024

Lets get 80% ! 👍

@yusukebe
Copy link
Member

Regarding the JSR score, I think it's okay to cover only public APIs. "comment" is not always good for private methods or properties. Perhaps you may find the spec by looking at the code or test, not the comment. Honestly, I don't like over-writing the comment. So, I think it's enough to write docs for the API marked as export, and we shouldn't be eager to get 100 points.

@EdamAme-x
Copy link
Contributor

Regarding the JSR score, I think it's okay to cover only public APIs. "comment" is not always good for private methods or properties. Perhaps you may find the spec by looking at the code or test, not the comment. Honestly, I don't like over-writing the comment. So, I think it's enough to write docs for the API marked as export, and we shouldn't be eager to get 100 points.

I agree. If we should be eager to get 100 points, it is too difficult to maintenance code.

@fzn0x
Copy link
Contributor Author

fzn0x commented May 30, 2024

I think it's enough to write docs for the API marked as export, and we shouldn't be eager to get 100 points.

Yes, I think public APIs alone is enough to get 80 points.

@EdamAme-x
Copy link
Contributor

Went up 3% by #2836
The main API is now mostly jsdoc added.

image

@HeyITGuyFixIt
Copy link
Contributor

HeyITGuyFixIt commented Oct 30, 2024

@yusukebe

Regarding the JSR score, I think it's okay to cover only public APIs.

The scoring is only concerned about the "presence of a README file, module documentation, and documentation for public functions and types." So documentation on private functions and types shouldn't affect the score. It looks like they updated the wording on the score page to clarify this. It is currently showing that 25% of exported symbols are documented.

@yusukebe
Copy link
Member

@HeyITGuyFixIt

Thanks for the information! Currently, the score of @hono/hono is 76%. It's good to be higher but I think we don't have to be eager for it. The user will use Hono if it's not a bad score.

CleanShot 2024-10-31 at 11 04 34@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

4 participants