Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sanitize SQL when reporting SQL queries #571

Merged
merged 5 commits into from
Jun 28, 2024
Merged

fix: sanitize SQL when reporting SQL queries #571

merged 5 commits into from
Jun 28, 2024

Conversation

stympy
Copy link
Member

@stympy stympy commented Jun 27, 2024

Replace strings like "where name = 'Bob'" with "where name = '?'"

Replace strings like "where name = 'Bob'" with "where name = '?'"
@stympy stympy requested review from roelbondoc and joshuap June 27, 2024 14:44
@rabidpraxis
Copy link
Contributor

@stympy
Copy link
Member Author

stympy commented Jun 27, 2024

We also have this class used for breadcrumbs: https://github.com/honeybadger-io/honeybadger-ruby/blob/master/lib/honeybadger/util/sql.rb

Thanks! 6ee8e24 :)

@stympy stympy merged commit 40d4a79 into master Jun 28, 2024
41 checks passed
@stympy stympy deleted the sanitize-sql branch June 28, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants