From 1c4ec601b9cf95513ee795a64b846dac83614c5a Mon Sep 17 00:00:00 2001 From: Northern Man <19808920+NorthernMan54@users.noreply.github.com> Date: Tue, 19 Sep 2023 08:03:58 -0400 Subject: [PATCH 1/4] Resolve issues with GitHub actions --- .github/workflows/build.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 165c892e1..2ec8c74b9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -15,7 +15,9 @@ jobs: uses: homebridge/.github/.github/workflows/nodejs-build-and-test.yml@main with: - enable_coverage: true + enable_coverage: false + ## Code Coverage can only be used in a single run, not in a parallel run - Error: Bad response: 422 {"message":"Can't add a job to a build that is already closed. Build 6224987022 is closed. See docs.coveralls.io/parallel-builds","error":true} + ## Coveralls only expects to create a report once per build runs_on: ${{ matrix.os }} install_cmd: npm ci && cd ui && npm ci secrets: From 38451f867e0af6bad577a111e3f703801fa5121d Mon Sep 17 00:00:00 2001 From: Northern Man <19808920+NorthernMan54@users.noreply.github.com> Date: Tue, 19 Sep 2023 08:12:04 -0400 Subject: [PATCH 2/4] Update build.yml Remove Node 20 support --- .github/workflows/build.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 2ec8c74b9..7034c7c2a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -29,20 +29,14 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest] - node-version: [18.x, 20.x] + node-version: [18.x] include: - os: macos-latest node-version: 18.x - - os: macos-latest - node-version: 20.x - os: windows-2019 node-version: 18.x - - os: windows-2019 - node-version: 20.x - os: windows-latest node-version: 18.x - - os: windows-latest - node-version: 20.x runs-on: ${{ matrix.os }} From f7462b187aa86fe7bed3ab3a794360d5c77e3543 Mon Sep 17 00:00:00 2001 From: Northern Man <19808920+NorthernMan54@users.noreply.github.com> Date: Tue, 19 Sep 2023 08:59:08 -0400 Subject: [PATCH 3/4] Update test.yml and temporarily remove Node 20 --- .github/workflows/test.yml | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 81664157f..d8a03a820 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -7,25 +7,19 @@ jobs: strategy: matrix: os: [ubuntu-latest] - node-version: [18.x, 20.x] + node-version: [18.x] include: - os: macos-latest node-version: 18.x - - os: macos-latest - node-version: 20.x - os: windows-2019 node-version: 18.x - - os: windows-2019 - node-version: 20.x - os: windows-latest node-version: 18.x - - os: windows-latest - node-version: 20.x runs-on: ${{ matrix.os }} steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }} From d4079d75ad9ca41c21bad0286dc98e05b6b46484 Mon Sep 17 00:00:00 2001 From: Northern Man <19808920+NorthernMan54@users.noreply.github.com> Date: Tue, 19 Sep 2023 09:37:49 -0400 Subject: [PATCH 4/4] Update win32.ts --- src/bin/platforms/win32.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/platforms/win32.ts b/src/bin/platforms/win32.ts index 7da16372a..95c2697a5 100644 --- a/src/bin/platforms/win32.ts +++ b/src/bin/platforms/win32.ts @@ -146,7 +146,7 @@ export class Win32Installer extends BasePlatform { * This is used to create the Windows Services */ private async downloadNssm(): Promise { - const downloadUrl = `https://github.com/homebridge/nssm/releases/download/2.24-101-g897c7ad/nssm_${os.arch()}.exe`; + const downloadUrl = `https://github.com/oznu/nssm/releases/download/2.24-101-g897c7ad/nssm_${os.arch()}.exe`; const nssmPath = path.resolve(this.hbService.storagePath, 'nssm.exe'); if (await fs.pathExists(nssmPath)) {