Remember gpslogger entities across restarts (fixes #24432) #24444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
integration: gpslogger
cla-needed
cla-signed
and removed
cla-needed
labels
balloob
pushed a commit
that referenced
this pull request
Jun 10, 2019
Merged
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Oct 12, 2019
…) (home-assistant#24444) * Remember gpslogger entities across restarts (fixes home-assistant#24432) * oops, missed those changes * Remove to do and set defaults to `None`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change
For the first restart device trackers will have a bogus location, because... well I didn't know any better ;-)
Maybe I'll have some more time tomorrow to investigate a bit further, but since this seems to affect other people I thought I'd just put it out there for people who are inclined to experiment
Related issue (if applicable): fixes #24432
Checklist:
tox. Your PR cannot be merged unless tests pass[dev-checklist]: https://developers.home-assistant.io/docs/en/development_checklist.html
I hope it's ok to put out an unfinished/experimental PR, it should at least give people something to start from if they want to take a stab at the same issue