-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script variable scopes #37720
Script variable scopes #37720
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThis change updates the documentation in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_docs/scripts.markdown (1)
861-862
: Refine Parallel Action Response Data Text
The new lines explaining that the response data of a parallelized action is available outside its scope are generally clear. However, consider streamlining the wording to remove redundancy and fix trailing whitespace. For instance, you might rephrase the text as follows:- - The response data of a parallelized {% term action %} is however also available outside of its own scope. This is especially useful for parallelizing execution of long-running {% term actions %}. + - The response data of a parallelized {% term action %} is also available outside the action's scope. This is especially useful for parallelizing the execution of long-running {% term actions %}.This edit removes the redundant phrase "its own" and addresses the trailing space issue.
🧰 Tools
🪛 LanguageTool
[style] ~861-~861: This phrase is redundant. Consider using “outside”.
Context: ...erm action %} is however also available outside of its own scope. This is especially use...(OUTSIDE_OF)
🪛 markdownlint-cli2 (0.17.2)
862-862: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_docs/scripts.markdown
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_docs/scripts.markdown
[style] ~861-~861: This phrase is redundant. Consider using “outside”.
Context: ...erm action %} is however also available outside of its own scope. This is especially use...
(OUTSIDE_OF)
🪛 markdownlint-cli2 (0.17.2)
source/_docs/scripts.markdown
862-862: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_docs/scripts.markdown (1)
97-97
: Clarify Local Variable Scope
The updated sentence clearly explains that variables defined via thevariables
action have a local scope—that is, changes in a nested sequence do not affect an outer block. This clarification is in line with the PR objectives and should help users understand variable isolation better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @arturpragacz 👍
Proposed change
Script variable scopes documentation.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit