-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onedrive option flow docs #37583
Conversation
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe changes update the OneDrive integration documentation by adding a new configuration option that allows users to permanently delete files, bypassing the Recycle Bin during backup cleanup. The relevant section in the main documentation file has been updated with this option, and a new file ( Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant BS as Backup System
participant OD as OneDrive API
U->>BS: Initiate backup cleanup
BS->>BS: Check deletion configuration
alt Permanent deletion enabled
BS->>OD: Delete file permanently (bypass Recycle Bin)
OD-->>BS: Confirmation of deletion
else Standard deletion
BS->>OD: Delete file (move to Recycle Bin)
OD-->>BS: Confirmation of deletion
end
BS-->>U: Report deletion status
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/onedrive.markdown (1)
40-43
: Improve Configuration Description Punctuation.
The added configuration block for "Delete files permanently:" contains minor punctuation issues (a double period at the end of the description and a potential missing comma). Consider revising the text for clarity and consistency with the documentation standards. For example, you might want to remove the extra period and adjust punctuation as needed.[typographical]
The following diff illustrates a possible revision:- description: By default files are put into the Recycle Bin when they are deleted, where they are available for another 30 days. If you enable this option, files will be deleted immediately when they are cleaned up by the backup system.. + description: By default, files are put into the Recycle Bin when deleted, where they remain available for another 30 days. If you enable this option, files will be deleted immediately when they are cleaned up by the backup system.🧰 Tools
🪛 LanguageTool
[uncategorized] ~42-~42: Possible missing comma found.
Context: ...te files permanently: description: By default files are put into the Recycle Bin when...(AI_HYDRA_LEO_MISSING_COMMA)
[typographical] ~42-~42: Two consecutive dots
Context: ...they are cleaned up by the backup system.. {% endconfiguration_basic %} ## Reques...(DOUBLE_PUNCTUATION)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/onedrive.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/onedrive.markdown
[uncategorized] ~42-~42: Possible missing comma found.
Context: ...te files permanently: description: By default files are put into the Recycle Bin when...
(AI_HYDRA_LEO_MISSING_COMMA)
[typographical] ~42-~42: Two consecutive dots
Context: ...they are cleaned up by the backup system.. {% endconfiguration_basic %} ## Reques...
(DOUBLE_PUNCTUATION)
🔇 Additional comments (1)
source/_integrations/onedrive.markdown (1)
38-38
: New Option Flow Inclusion.
The documentation now includes{% include integrations/option_flow.md %}
, which introduces the new option flow details. Please verify that the referenced file exists and that its content matches the intended configuration for OneDrive.
Proposed change
SSIA
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit