-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voice Preview Edition display and content fixes #36447
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces updates to the Home Assistant Voice Preview Edition landing page, focusing on improving the Changes
Sequence DiagramsequenceDiagram
participant User
participant VoiceAssistant
participant LocalProcessor
participant CloudProcessor
User->>VoiceAssistant: Speak command
alt Local Processing
VoiceAssistant->>LocalProcessor: Process voice
LocalProcessor-->>VoiceAssistant: Return result
else Cloud Processing
VoiceAssistant->>CloudProcessor: Send voice data
CloudProcessor-->>VoiceAssistant: Return processed result
end
VoiceAssistant->>User: Execute command
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/voice-pe/styles.css (1)
119-120
: Consider specifying “display: block” and “visibility: visible”.
“initial” in CSS resets the property to the browser’s default, which can sometimes lead to unexpected layout or visibility differences across various browsers. Explicitly specifying “block” and “visible” might be more predictable.source/voice-pe/index.html (1)
481-481
: Clarify hardware requirements.
“Processing is pretty accurate” is a bit informal and ambiguous for a technical audience. Consider specifying accurate conditions or disclaimers about potential hardware constraints.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
source/voice-pe/index.html
(2 hunks)source/voice-pe/styles.css
(1 hunks)
🔇 Additional comments (2)
source/voice-pe/index.html (2)
436-436
: Good grammar fix – “it’s” instead of “its”.
Thanks for improving clarity and correctness here.
489-489
: Well-stated explanation of cloud processing benefits.
It’s clearly conveyed that cloud processing provides improved speed and accuracy for low-powered devices. No changes needed.
Proposed change
:target
was active (fragment scrolling)Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
New Features
Bug Fixes
Style
Chores