Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Risco set_time service #139015

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

FredericMa
Copy link
Contributor

@FredericMa FredericMa commented Feb 21, 2025

Proposed change

This PR adds a set_time service to the Risco integration to set the time of the alarm panel on a local connection.
Reasoning behind it: The panel I have only allows one connection so it doesn't seem to be able to sync the time with a timeserver although it is configured to do so. Over a few weeks time there is a drift of 8 minutes between the current time and the time of the panel.
This service makes it possible to create an automation to update the time of the panel at a preferred interval.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @OnFreund, mind taking a look at this pull request as it has been labeled with an integration (risco) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of risco can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign risco Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@OnFreund
Copy link
Contributor

Please split the dependency bump to a separate PR.
The refactoring should probably be a separate PR as well.

@FredericMa FredericMa marked this pull request as draft February 22, 2025 18:29
@MartinHjelmare MartinHjelmare changed the title Risco - Add set_time service Add Risco set_time service Feb 22, 2025
@FredericMa FredericMa closed this Feb 23, 2025
@FredericMa FredericMa reopened this Feb 23, 2025
@FredericMa FredericMa marked this pull request as ready for review February 23, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants